simpler heartbeat based on health #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsippl
requested review from
danielle-tfh,
wojciechsromek and
carlomazzaferro
|
@philsippl this will be needed before-hand: #601 It would also make sense to include some checks for DB connectivity / correct working of the queue processing checks, because otherwise this would basically be a liveness check, not healthiness one. Wdyt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NCCL heartbeat has always been a troublemaker and wasn't anyways testing the health of the NCCL connections that are actually used in the main thread.
This now just uses the
/healthendpoint and exposes a unique id to the other nodes. If the other nodes notice the unique id has changed they restart.Note: This requires a new config entry to be added (without port).
SMPC__NODE_HOSTNAMES='["...", "...", "..."]'