Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HawkPack version #593

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Update HawkPack version #593

merged 5 commits into from
Oct 29, 2024

Conversation

rdragos
Copy link
Collaborator

@rdragos rdragos commented Oct 25, 2024

This PR resolves the compatibility issues with the newest api from hawkpack

@rdragos rdragos marked this pull request as ready for review October 25, 2024 16:06
) -> eyre::Result<HawkSearcher<LocalNetAby3NgStoreProtocol, GraphMem<LocalNetAby3NgStoreProtocol>>>
{
) -> eyre::Result<(
LocalNetAby3NgStoreProtocol,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you could create a struct for such tuples called "Context" or something.

Copy link
Collaborator

@iliailia iliailia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo some tiny refactoring

@rdragos rdragos merged commit 5b7b846 into main Oct 29, 2024
11 checks passed
@rdragos rdragos deleted the dragos/update-hawk-pack branch October 29, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants