Measure execution times of streams #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkales
reviewed
Aug 8, 2024
src/bin/server.rs
Outdated
Comment on lines
575
to
591
| // drop actor handle to initiate shutdown | ||
| drop(handle); | ||
|
|
||
| println!( | ||
| "Total time for {} iterations: {:?}", | ||
| N_BATCHES - 1, | ||
| total_time.elapsed() - batch_times | ||
| ); | ||
|
|
||
| // Clean up server tasks, then wait for them to finish | ||
| background_tasks.abort_all(); | ||
| tokio::time::sleep(Duration::from_secs(5)).await; | ||
|
|
||
| // Check for background task hangs and shutdown panics | ||
| background_tasks.check_tasks_finished(); | ||
|
|
||
| Ok(()) |
There was a problem hiding this comment.
Idk if we need a "clean" shutdown for the Server actor, by putting the loop in a try able block and doing the shutdown here on error?
src/server/actor.rs
Outdated
| $manager.record_event($streams, &evt0); | ||
| $block | ||
| $manager.record_event($streams, &evt1); | ||
| $map.insert($label, vec![evt0, evt1]); |
There was a problem hiding this comment.
do you want something like $map.entry($label).or_default().extend(&[evt0, evt1]). I think atm you override the dot_events in each batch iteration.
src/server/actor.rs
Outdated
Comment on lines
821
to
822
| .windows(2) | ||
| .step_by(2) |
There was a problem hiding this comment.
This is simulating chunks(2)?
|
I also touched a few of the |
dkales
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Measures and aggregates execution times of GPU workload. This is useful for benchmarking and production monitoring.
TODO (followup PR): send this to datadog as a gauge metric