feat: Bound dataset query to location search results #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eojson on request payload
rgbongocan
commented
Jan 18, 2024
| @@ -3,6 +3,7 @@ server { | |||
| server_name localhost; | |||
| root /usr/share/nginx/html; | |||
| index index.html; | |||
| client_max_body_size 10m; | |||
There was a problem hiding this comment.
By default this is 1m (megabyte) and gets tripped when the geojson from the nominatim search result is included in the request payload to our backend api. We have other options to consider in the future:
- Determine an appropriate value for polygon_threshold to request a simplified polygon from nominatim. Oversimplification can mean we miss or mistakenly capture some h3 tiles
- Pass the place id instead of the geojson to the api backend - and let it re-call the nominatim endpoint. Given we request in batches corresponding to osm tiles, one concern is that this will fire too many of the same requests (and abuse) to the nominatim api
…to return datasets captured by a geojson
…ns for better performance
rgbongocan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todos on separate PR
overlappingmode for polygon fill for "better" coverageDescription
Addresses #85 - dataset count and coverage layers will be restricted in terms of h3 tiles displayed based on the location search results (if used).
The datasets captured by a location search result will also be displayed by default provided a tile isn't selected.
Screenshots