Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata for the new appstream validator #100

Merged
merged 4 commits into from
Mar 10, 2024
Merged

Fix metadata for the new appstream validator #100

merged 4 commits into from
Mar 10, 2024

Conversation

sonnyp
Copy link
Contributor

@sonnyp sonnyp commented Mar 10, 2024

No description provided.

Comment on lines +75 to +76
<color type="primary" scheme_preference="light">#99c1f1</color>
<color type="primary" scheme_preference="dark">#1c71d8</color>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blue 1 and 4 from the GNOME color palette

https://docs.flathub.org/blog/introducing-app-brand-colors/

@sonnyp sonnyp marked this pull request as ready for review March 10, 2024 10:42
@@ -3,17 +3,20 @@
<id>@app_id@</id>
<launchable type="desktop-id">@[email protected]</launchable>
<name translatable="no">Biblioteca</name>
<developer_name translatable="no">Akshay Warrier</developer_name>
<developer id="com.github.AkshayWarrier">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ximion/appstream#617

I want to see if upper case is a blocker on Flathub

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't validate developer-id on Flathub, but upstream appstream is forbids it like you found.

@sonnyp sonnyp requested a review from AkshayWarrier March 10, 2024 10:58
@AkshayWarrier
Copy link
Collaborator

I ran flatpak run --command=flatpak-builder-lint org.flatpak.Builder appstream data/app.metainfo.xml and I get the following

E: @app_id@:3: cid-punctuation-prefix @app_id@
   The component ID starts with punctuation. This is not allowed.

E: @app_id@:3: cid-desktopapp-is-not-rdns @app_id@
   The component ID is not a reverse domain-name. Please update the ID to avoid future issues and
   be compatible with all AppStream implementations.
   You may also consider to update the name of the accompanying .desktop file to follow the latest
   version of the Desktop-Entry specification and use a rDNS name for it as well. In any case, do
   not forget to mention the new desktop-entry in a <launchable/> tag for this component to keep
   the application launchable from software centers and the .desktop file data associated with the
   metainfo data.

E: @app_id@:3: cid-invalid-character @app_id@: '@'
   The component ID contains an invalid character. Only ASCII characters, dots and numbers are
   permitted.

I: @app_id@:6: developer-id-invalid com.github.AkshayWarrier
   The developer-ID is invalid. It should be an rDNS string identifying the developer, or a
   Fediverse handle. It must also only contain lowercase ASCII letters, numbers and punctuation.

I: @app_id@:61: nonstandard-gnome-extension kudos
   This tag is a GNOME-specific extension to AppStream and not part of the official specification.
   Do not expect it to work in all implementations and in all software centers.

are these all normal?

@sonnyp
Copy link
Contributor Author

sonnyp commented Mar 10, 2024

yes - that's because you give it the non "compiled" metainfo where @app_id@ hasn't been replaced by meson

@sonnyp sonnyp merged commit 91a759d into main Mar 10, 2024
@sonnyp sonnyp deleted the fix-metadata branch March 10, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants