Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 달력 확정 페이지 ConfirmModal 추가 및 로그인 후 라우팅 경로 수정 #426

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

Largopie
Copy link
Contributor

관련 이슈

작업 내용

  • 로그인 시 라우팅 경로 /meeting/:uuid -> /meeting/:uuid/register로 변경
  • ConfirmModal 날짜만 선택 옵션 사용 시에도 동작하도록 수정
2024-10-25.12.30.46.mov

특이 사항

없습니다~!

리뷰 요구사항 (선택)

@Largopie Largopie added 🐈 프론트엔드 프론트엔드 관련 이슈에요 :) 🛠️ 픽스 버그를 해결했어요 :) labels Oct 24, 2024
@Largopie Largopie added this to the 6차(최종) 데모데이 milestone Oct 24, 2024
@Largopie Largopie self-assigned this Oct 24, 2024
Copy link

Test Results

35 tests   - 121   35 ✅  - 121   24s ⏱️ +3s
 4 suites  -  28    0 💤 ±  0 
 1 files    -  31    0 ❌ ±  0 

Results for commit 8d3cfcf. ± Comparison against base commit 4d56935.

Copy link
Contributor

@Yoonkyoungme Yoonkyoungme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐪🐫🐪🐫
영상 첨부해주신 점이 너무 좋네요~~

@@ -22,7 +22,7 @@ export const usePostLoginMutation = () => {

setIsLoggedIn(true);
setUserName(userName);
routeTo(`/meeting/${uuid}`);
routeTo(`/meeting/${uuid}/register`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사해요 🐫 🐪

Copy link
Contributor

@hwinkr hwinkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...!

@Largopie Largopie merged commit 3eef848 into develop Oct 24, 2024
11 checks passed
@Largopie Largopie deleted the fix/425-route-and-confirm-modal branch October 24, 2024 15:49
hwinkr pushed a commit that referenced this pull request Oct 25, 2024
* refactor: 로그인 시, 등록 페이지로 이동하도록 라우팅 경로 수정

* feat: 날짜만 조회 선택 후 확정 페이지 이동 시 ConfirmModal을 띄우도록 추가
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐈 프론트엔드 프론트엔드 관련 이슈에요 :) 🛠️ 픽스 버그를 해결했어요 :)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants