[BE] 인원 수정 및 삭제 API 통합 #964
Open
+65
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soi-ha
approved these changes
Jan 21, 2025
Comment on lines
+74
to
+86
|
|
||
| deleteMembers(token, originEventMembers, updatedMembers); | ||
| eventMemberRepository.saveAll(updatedMembers.getMembers()); | ||
| } | ||
|
|
||
| private void deleteMembers(String token, List<EventMember> originEventMembers, UpdatedMembers updatedMembers) { | ||
| for (EventMember originEventMember : originEventMembers) { | ||
| if (!updatedMembers.contain(originEventMember)) { | ||
| deleteMember(token, originEventMember); | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
pr에 써주신 것처럼
1,2,3이 있다고 했을 때, 1은 상태 변화가 있고 2,3은 없다면. 그리고 3을 삭제하고 싶다면
1,2만 PUT 요청하면 된다는 것이죠?
There was a problem hiding this comment.
맞아요! 프론트 작업 끝나면 같이 머지해야겠네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
API
/api/admin/events/{eventId}/members
Request
{ "members" : [ { "id" : 1, "name" : "토다리", "isDeposited": true }, { "id" : 2, "name" : "망쵸", "isDeposited": false } ] }구현 사항
멤버 정보 수정 API 호출시 누락된 member는 자동으로 삭제 됩니다.
(id 1,2,3 인 멤버가 존재하는 경우 id 1,2 만 수정 요청시 id 3은 삭제됨)