Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/#545 s3 설정 외부로 #546

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Conversation

hectick
Copy link
Collaborator

@hectick hectick commented Nov 17, 2023

🔥 연관 이슈

📝 작업 요약

s3 버킷 마이그레이션 과정에서 s3 정보를 외부로 빼내기로 결정하였습니다.
자세한 내용은 이슈 참고

@hectick hectick closed this Nov 17, 2023
@hectick hectick reopened this Nov 17, 2023
@hectick hectick closed this Nov 17, 2023
@hectick hectick reopened this Nov 17, 2023
@hectick hectick changed the base branch from main to dev November 17, 2023 08:28
@hectick hectick changed the title Hotfix/#545 s3 설정 외부로 refactor/#545 s3 설정 외부로 Nov 17, 2023
Copy link

github-actions bot commented Nov 17, 2023

Unit Test Results

  70 files  +  3    70 suites  +3   24s ⏱️ -6s
369 tests +12  369 ✔️ +12  0 💤 ±0  0 ±0 
372 runs  +12  372 ✔️ +12  0 💤 ±0  0 ±0 

Results for commit 3516f39. ± Comparison against base commit 7aacd0d.

This pull request removes 3 and adds 15 tests. Note that renamed tests count towards both.
edonymyeon.backend.auth.application.AuthServiceTest ‑ 로그인 이후 디바이스 교체 작업을 수행한다
edonymyeon.backend.auth.application.AuthServiceTest ‑ 소셜로그인 이후에도 디바이스 교체 작업을 수행한다
edonymyeon.backend.member.domain.MemberTest ‑ 비밀번호 암호화시 잘못 암호화된 비밀번호가 들어오면 예외발생
edonymyeon.backend.auth.application.AuthServiceTest ‑ 로그인 이후 디바이스 교체 작업을 수행한다 (DeviceRepository)
edonymyeon.backend.auth.application.AuthServiceTest ‑ 소셜로그인 이후에도 디바이스 교체 작업을 수행한다 (DeviceRepository)
edonymyeon.backend.auth.application.AuthServiceTest ‑ 최초의 소셜로그인시 사용한 디바이스 정보를 함께 저장한다 (EntityManager)
edonymyeon.backend.member.domain.EmailTest ‑ 이메일을 SocialType으로 생성한다
edonymyeon.backend.member.domain.EmailTest ‑ 이메일을 String으로 생성한다
edonymyeon.backend.member.domain.EmailTest ‑ 이메일이 30글자를 초과하면 예외가 발생한다
edonymyeon.backend.member.domain.NicknameTest ‑ 닉네임을 SocialType으로 생성한다
edonymyeon.backend.member.domain.NicknameTest ‑ 닉네임을 String으로 생성한다
edonymyeon.backend.member.domain.NicknameTest ‑ 닉네임이 20글자를 초과하면 예외가 발생한다
edonymyeon.backend.member.domain.PasswordTest ‑ 비밀번호가 30글자를 초과하면 예외가 발생한다
…

♻️ This comment has been updated with latest results.

@hectick hectick merged commit e2dfa4d into dev Nov 17, 2023
4 of 5 checks passed
@hectick hectick deleted the hotfix/#545_s3_설정_외부로 branch November 17, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3 설정 외부로 변경하기
1 participant