Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
클래스단에 달려있는
@Transactional(readOnly = true)
가 자꾸 괴롭히는군용카카오톡에서도 이야기를 했지만 메모를 해봅니다.
일단 login메서드에
@Transactional
어노테이션을 달아줌으로써 해결하긴 하였으나,login 메서드에서는 이벤트를 제외하면 조회해서 체크하는 로직밖에 없기 때문에
과연 login메서드가 이벤트에서 쓰기연산이 발생할 일을 파악해서
@Transactional
을 쓰도록 바꾸는 것이 맞는것인가?하는 생각이 갑자기 들었습니다.
그렇다고 디바이스를 활성화/비활성화하는 메서드에 Require_new를 달자니 데드락이 걸리네요
결론: 이참에
파사드 패턴
을 고려해보는 것이 어떨까요 ~