Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

게시글 등록/ 수정시 이미지를 batch insert 하도록 수정함 #528

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

jyeost
Copy link
Collaborator

@jyeost jyeost commented Nov 2, 2023

🔥 연관 이슈

📝 작업 요약

이미지 업로드 후 이미지 정보들을 saveAll 해주던 것을 수정했습니다 !!
스크린샷 2023-11-02 오후 9 57 18
스크린샷 2023-11-02 오후 9 58 41

🌟 리뷰 요구 사항

아래 pr 머지되면 수정에서도 이 메서드를 사용하도록 바꿀 예정입니다

@jyeost jyeost self-assigned this Nov 2, 2023
@jyeost jyeost added ❤️ Backend for BackEnd 🛠️ refactor Auto-Deploy for jenkins auto deploy labels Nov 2, 2023
@jyeost jyeost requested review from This2sho, BackFoxx and hectick and removed request for This2sho and BackFoxx November 2, 2023 13:04
Copy link

github-actions bot commented Nov 2, 2023

Unit Test Results

  70 files  ±0    70 suites  ±0   23s ⏱️ -7s
368 tests ±0  368 ✔️ ±0  0 💤 ±0  0 ±0 
371 runs  ±0  371 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 4a44e49. ± Comparison against base commit 70b333f.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@BackFoxx BackFoxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘하셨어요 케로~!!
이 변경사항은 h2로 확인할 수 없기 때문에,
testContainer를 사용하는 방법을 공부해서 다음에 적용해봐야겠어욥 ㅠ.ㅠ

Copy link
Collaborator

@hectick hectick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

머지된거 반영해서 게시글 수정에도 batch save 해주시면 리부 할게욤 ><

…atch_insert

# Conflicts:
#	backend/src/main/java/edonymyeon/backend/image/postimage/repository/PostImageInfoRepository.java
#	backend/src/main/java/edonymyeon/backend/post/application/PostService.java
@BackFoxx BackFoxx merged commit 151ecba into dev Nov 20, 2023
3 checks passed
@BackFoxx BackFoxx deleted the refactor/#527_게시글이미지_batch_insert branch November 20, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Deploy for jenkins auto deploy ❤️ Backend for BackEnd 🛠️ refactor
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

게시글 작성, 수정시 이미지 정보를 saveAll로 저장하는 것을 batch insert로 수정
3 participants