Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sujin9
approved these changes
Oct 16, 2023
Comment on lines
178
to
179
| price = | ||
| makeCommaNumber(binding.etPostPrice.text.toString().replace(",", "").toInt()) |
There was a problem hiding this comment.
Suggested change
| price = | |
| makeCommaNumber(binding.etPostPrice.text.toString().replace(",", "").toInt()) | |
| price = getString(R.string.all_price, binding.etPostPrice.text.toString().replace(",", "").toInt()) |
strings.xml에 all_price 라는 리소스가 있어서
이걸 활용해도 좋을 것 같아요!
| @@ -95,7 +95,6 @@ | |||
| android:background="@android:color/transparent" | |||
| android:hint="@string/post_editor_price_hint" | |||
| android:inputType="number" | |||
| android:onTextChanged="@{viewModel.checkPriceValidate}" | |||
| android:text="@{viewModel.postEditor.price}" | |||
There was a problem hiding this comment.
android:textAlignment="textEnd"도 추가해보는건 어떨까요?
123,000 원 이 아니라
123,000원 으로 오른쪽 정렬되어 가격이 보입니다 !
rhkrwngud445
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
📝 작업 요약
PostEditorActivity에서 금액 입력 부분에 대한 처리를 진행하였습니다.
🔎 작업 상세 설명
기존의 금액 입력은 단위를 명시하지 않아 얼마를 적었는지 알기 어려웠기 때문에 ,를 통해 얼마인지를 알 수 있도록 하였습니다.
또한, 금액 입력 초과 시 기존에는 snackbar와 함께 입력된 값이 사라지도록 하였었는데 이번에 리팩토링을 진행하면서
금액 초과 시 값을 입력하면 snackbar가 계속 뜨지만 값은 반영되지 않도록 하였습니다!
🌟 리뷰 요구 사항
코드가 많이 추가된 것은 아니기 때문에 TextWatcher 부분 위주로 봐주시면 될 것 같습니다!!
또 발견하지 못한 오류가 있을 수 있으니 확인 부탁드려요😄