Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#485 빈화면문구추가 #492

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Conversation

Choisehyeon
Copy link
Collaborator

🔥 연관 이슈

📝 작업 요약

화면이 비어 있는 경우 문구 추가

🔎 작업 상세 설명

내가 쓴 글 화면과 검색 화면에서 비어있는 경우 해당 화면과 맞는 문구 보여주도록 구현

🌟 리뷰 요구 사항

5분도 안 걸릴 간단한 이슈입니다!! 오류가 있는 봐주시면 감사하겠습니다😊

@Choisehyeon Choisehyeon added 💚 Android for Android ⚡️ feature New feature or request labels Oct 15, 2023
@Choisehyeon Choisehyeon added this to the 6차 데모데이 milestone Oct 15, 2023
@Choisehyeon Choisehyeon self-assigned this Oct 15, 2023
@github-actions
Copy link

github-actions bot commented Oct 15, 2023

Test Results

43 tests   43 ✔️  0s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit fc81d44.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@sujin9 sujin9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정보가 없음을 알려주니 훨씬 좋아요! 👍

한 가지 가벼운 제안 사항 하나가 있는데요~
처음 검색 프래그먼트 들어오거나 검색어가 없는 경우에는 문구가 보이지 않도록 하면 어떨까요?

override fun onQueryTextChange(newText: String?): Boolean {
    if (newText == "") binding.tvEmptyPost.isVisible = false // 코드 한 줄 추가 !
    return true
}

@sujin9 sujin9 requested a review from rhkrwngud445 October 16, 2023 06:10
Copy link
Collaborator

@rhkrwngud445 rhkrwngud445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳 좋습니다~!

@Choisehyeon Choisehyeon merged commit 0ebec08 into dev Oct 17, 2023
@Choisehyeon Choisehyeon deleted the feat/#485_빈화면문구추가 branch October 17, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💚 Android for Android ⚡️ feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

검색 화면과 내가 쓴 글 화면에서 데이터가 없을 시 문구를 보여주도록 추가
3 participants