안드로이드 CD 개선 희망 (#516)

* Update android-ci-workflow.yml * Update Email.kt * Update android-ci-workflow.yml * Update build.gradle.kts * Rollback build.gradle.kts * Update android-ci-workflow.yml
woowacourse-teams · Nov 6, 2023 · 82a0b87 · 82a0b87
1 parent d176d38
commit 82a0b87
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/.github/workflows/android-ci-workflow.yml b/.github/workflows/android-ci-workflow.yml
@@ -34,15 +34,15 @@ jobs:
       env:
         BASE_URL: ${{ secrets.APP_BASE_URL }}
       run: |
-        echo "APP_BASE_URL=\"BASE_URL\"" >> ./local.properties
+        echo "APP_BASE_URL=\"$BASE_URL\"" >> local.properties
 
     - name: Access KAKAO KEY
       env:
         APP_KEY: ${{ secrets.KAKAO_APP_KEY }}
         NATIVE_KEY: ${{ secrets.KAKAO_NATIVE_KEY }}
       run: |
-        echo "KAKAO_APP_KEY=\"APP_KEY\"" >> ./local.properties
-        echo "KAKAO_NATIVE_KEY=\"NATIVE_KEY\"" >> ./local.properties
+        echo "KAKAO_APP_KEY=\"$APP_KEY\"" >> local.properties
+        echo "KAKAO_NATIVE_KEY=\"$NATIVE_KEY\"" >> local.properties
         
     - name: set up Java JDK 17
       uses: actions/setup-java@v3

diff --git a/android/domain/src/main/java/com/domain/edonymyeon/model/Email.kt b/android/domain/src/main/java/com/domain/edonymyeon/model/Email.kt
@@ -5,7 +5,6 @@ value class Email private constructor(val value: String) {
     init {
         require(validate(value)) { ERROR_NEGATIVE_EMAIL }
     }
-
     companion object {
         fun validate(value: String): Boolean = Regex(Email_REGEX).matches(value)
-Original file line number
+Diff line change
@@ Expand Up / @@ -5,7 +5,6 @@ value class Email private constructor(val value: String) { @@
         init {
             require(validate(value)) { ERROR_NEGATIVE_EMAIL }
         }
         companion object {
             fun validate(value: String): Boolean = Regex(Email_REGEX).matches(value)
@@ Expand Down @@