Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Details: Display cover tag on the first product image #15041

Merged
merged 8 commits into from
Feb 5, 2025

Conversation

itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Feb 3, 2025

Closes: #15039

Description

This PR addresses a confusion among users about cover images of products. The solution is to simply display a label "Cover" on the first image of both the product form and the product image list screens. The helper text on the product image list screen also mentions the cover text being set for the first image to make this clearer.

Steps to reproduce

  • Log in to a test store.
  • Open an existing product or create a new one.
  • Upload one or more images for the product as needed.
  • Confirm that the first image listed on the product form has the "Cover" label while the rest don't.
  • Confirm that the label looks good in both light and dark modes.
  • Select any image to open the image list screen.
  • Confirm that the first image on this screen also displays the "Cover" label.
  • Confirm that the helper text on this screen includes the detail about the cover image.
  • Drag and drop images and confirm that the "Cover" label is updated correctly for the images.

Testing information

Tested on simulator iPhone 16 Pro iOS 18.2 and confirmed that the "Cover" label looks good in both dark and light modes and in different text sizes. The label is updated correctly when the images positions are updated.

Screenshots

Screen Light mode Dark mode
Product form
Photos

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

TODO: @itsmeichigo to update the release notes for 21.7 after the code freeze of 21.6 is done.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: product details Related to adding or editing products, including Product Settings. labels Feb 3, 2025
@itsmeichigo itsmeichigo added this to the 21.7 milestone Feb 3, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 3, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15041-7439764
Version21.6
Bundle IDcom.automattic.alpha.woocommerce
Commit7439764
App Center BuildWooCommerce - Prototype Builds #12780
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review February 3, 2025 10:01
Copy link
Member

@pmusolino pmusolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in white/dark mode and also with larget text. Everything works like a charm. :shipit:

@itsmeichigo itsmeichigo merged commit 7e6c816 into trunk Feb 5, 2025
12 checks passed
@itsmeichigo itsmeichigo deleted the task/15039-indicate-cover-image branch February 5, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: product details Related to adding or editing products, including Product Settings. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicate which image is used as cover
3 participants