Skip to content

Commit

Permalink
Use HTTPS instead of HTTP in test.com URL in unit tests
Browse files Browse the repository at this point in the history
I notice a TSAN warning in the Wormholy library:

> App Transport Security has blocked a cleartext HTTP connection
> totest.comsince [sic] it is insecure. Use HTTPS instead or add this domain
> to Exception Domains in your Info.plist.
  • Loading branch information
mokagio committed Dec 7, 2022
1 parent dcb836d commit ce85caf
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import XCTest

final class JetpackConnectionRemoteTests: XCTestCase {

private let siteURL = "http://test.com"
private let siteURL = "https://test.com"

/// Dummy Network Wrapper
///
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import XCTest

final class WordPressOrgRequestTests: XCTestCase {

private let baseURL = "http://test.com"
private let baseURL = "https://test.com"
private let path = "/test/request"

func test_request_url_is_correct() throws {
Expand All @@ -14,7 +14,7 @@ final class WordPressOrgRequestTests: XCTestCase {
let url = try XCTUnwrap(request.asURLRequest().url)

// Then
let expectedURL = "http://test.com/wp-json/test/request"
let expectedURL = "https://test.com/wp-json/test/request"
assertEqual(url.absoluteString, expectedURL)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import Yosemite
/// Test cases for `AuthenticationManager`.
final class AuthenticationManagerTests: XCTestCase {

let testSiteURL = "http://test.com"
let testSiteURL = "https://test.com"

/// We do not allow automatic WPCOM account sign-up if the user entered an email that is not
/// registered in WordPress.com. This configuration is set up in
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import XCTest

final class JetpackConnectionStoreTests: XCTestCase {

private let siteURL = "http://test.com"
private let siteURL = "https://test.com"

/// Mock Dispatcher
///
Expand Down

0 comments on commit ce85caf

Please sign in to comment.