Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E tests for WC 9.6 #483

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fix E2E tests for WC 9.6 #483

merged 1 commit into from
Jan 13, 2025

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Jan 10, 2025

Changes proposed in this Pull Request:

Test are failing for 9.6.0

As it happened in Google for WooCommerce.
The reason is that Comming Soon page is blocking the store. So I did add a statement to disable the coming soon page.

Checks:

  • Does your code follow the WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Screenshots:

Detailed test instructions:

  1. See the E2E tests passing for 9.6.0-beta.2

Additional details:

Changelog entry

Dev - Fix E2E tests for WC 9.6

@puntope puntope self-assigned this Jan 10, 2025
@puntope puntope requested a review from a team January 10, 2025 18:07
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Jan 10, 2025
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM.

@puntope puntope merged commit a3ae452 into trunk Jan 13, 2025
3 checks passed
@puntope puntope deleted the dev/fix-e2e-9.6 branch January 13, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants