Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install SVN on PHP unit test runner #476

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Install SVN on PHP unit test runner #476

merged 1 commit into from
Dec 14, 2024

Conversation

tomalec
Copy link
Member

@tomalec tomalec commented Dec 12, 2024

Changes proposed in this Pull Request:

Install SVN on PHP unit test runner

As the latest Ubuntu does not have it preinstalled

woocommerce/google-listings-and-ads#2723 for the reference

Screenshots:

Detailed test instructions:

  1. Check the PHP unit tests are running successfully for this branch.
  2. Check that the manual workflow works as well

Additional details:

Changelog entry

Dev - Fix PHP unit tests - install svn.

As the latest Ubuntu does not have it preinstalled
@tomalec tomalec requested a review from a team December 12, 2024 22:53
@tomalec tomalec self-assigned this Dec 12, 2024
@github-actions github-actions bot added the changelog: dev Developer-facing only change. label Dec 12, 2024
Copy link
Contributor

@mikkamp mikkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I can see the php unit tests passing on the newer Ubuntu version:
image

@tomalec tomalec merged commit b1b3c02 into trunk Dec 14, 2024
11 of 13 checks passed
@tomalec tomalec deleted the dev/svn-in-tests branch December 14, 2024 20:52
@eason9487 eason9487 mentioned this pull request Dec 18, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants