Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude the @since existence check sniff rule #238

Merged
merged 2 commits into from
Jul 20, 2024
Merged

Exclude the @since existence check sniff rule #238

merged 2 commits into from
Jul 20, 2024

Conversation

qasumitbagthariya
Copy link
Contributor

@qasumitbagthariya qasumitbagthariya commented Jul 4, 2024 •
edited by vikrampm1
Loading

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

This PR excludes the @since existence check sniff to avoid errors when x.x.x is set.

Closes #235

Steps to test the changes in this Pull Request:

See the reproduction steps in the linked Issue.

image

Changelog entry

Dev - Exclude the Woo Comment Hook @since sniff.

@qasumitbagthariya qasumitbagthariya linked an issue Jul 4, 2024 that may be closed by this pull request
WooCommerce PHPCS sniff throws an error when using @since x.x.x on hooks #235
Closed
@qasumitbagthariya qasumitbagthariya requested a review from dkotter July 4, 2024 11:46
@vikrampm1 vikrampm1 added this to the 1.6.6 milestone Jul 20, 2024
@vikrampm1 vikrampm1 marked this pull request as ready for review July 20, 2024 15:38
@vikrampm1 vikrampm1 merged commit 3b9d8f4 into trunk Jul 20, 2024
5 checks passed
@vikrampm1 vikrampm1 deleted the fix/235 branch July 20, 2024 15:39
@vikrampm1 vikrampm1 mentioned this pull request Jul 26, 2024
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@qasumitbagthariya qasumitbagthariya

Labels
None yet
Projects
None yet
Milestone
1.6.6
Development

Successfully merging this pull request may close these issues.

WooCommerce PHPCS sniff throws an error when using @since x.x.x on hooks
3 participants
@qasumitbagthariya @dkotter @vikrampm1