-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dark mode illustrations #13392
Update dark mode illustrations #13392
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Hey @irfano nicely done! I was able to test almost all the cases. However there's one screen I was not able to test: How do you log in with an account without any sites? Because we currently force the user to enter a site url, so I always land on this screens: deleted.mp4(I've deleted that single site that is shown on the list, but still shows there, so the site picker is never empty) Also I wanted to ask about this illustration from the flow above. Is it correct? Because it feels like it has the "old" look and feel, despite having the new Woo logo there: Lastly, wanted to ask about the WooCommerce branding on the login email template. Is it under your radar to report this to get it updated? Because it currently shows the old style: |
I removed the user from the site after logging in. I added the instructions to the description.
Yes, that's correct. We only updated the logo and colors on it. Figma reference: Ntkk0ER4hHt5y9KjEGIiGk-fi-3450_5600
It’s expected that it’s currently showing the old logo for now. But I still reported it to ensure that updating it is included in our plans. (Internal link: p1738072483131849-slack-C07E7D0R761) |
Description
During the design review, it was commented that the illustrations we use for Jetpack setup flow don't look great in dark theme, so we got new versions that use lighter purple, this PR updates those illustrations.
I also forgot to update the light mode of empty store picker illustration, and updated it here.
Steps to reproduce
Checking the screenshots below should be enough.
Reproduce Empty Site Picker
The tests that have been performed
Screens below
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: