[Image Uploads Improvement] Add entry points to the error screen

[hafizrahman]

Closes: #13419

Description

Adds a new permanent CTA when product image uploads fail, so that user can access an error screen to see the details of the failed upload an retry. The behavior of this new CTA is as follows:

• It will be shown as soon as the first image upload error happens
• It will stay visible until "Add photos is tapped again" for the given product. Or when navigating back from product detail with unsaved changes and clicking "Discard" changes from the confirm exit dialog CTA.
• Currently, when the app is killed all upload errors are cleared (because we keep them in memory). This behavior probably makes sense since killing the app will also cancel the ongoing uploads.
• A snack bar is shown for a few seconds for every upload error that happens. We might want to get rid of this snackbar in iteration II completely. Something to discuss with Ann. But for now I think it provides better visibility for each time an upload fails.

Steps to reproduce

Before running the testing steps, enable API Faker to make upload media requests. Apply the following changes from More menu > Settings > Developer Options > API faker:

Testing information

With API faker is enabled:

1. Open product detail
2. Open the product images screen
3. Tap Add photos
4. Tap Choose from device
5. Select a photo and let the uploads fail.
6. See how a snackbar with the number of failed uploads is shown for a couple of seconds
7. See the new CTA "View recent upload failures" is shown
8. Tap on it, and enter error screen. Navigate back.
9. Navigate back to product detail and check the new "View recent upload failures" is shown
10. Tap on it and click retry.
11. See how you are taken back to the previous screen while the retry happens
12. After getting some upload errors, edit some data from the product detail, then navigate back, tap on "DIscard" cta from confirmation dialog. Once landed on the product list, reopen the same product detail and check the button "View recent upload failures" is gone.

The tests that have been performed

The above

Images/gif

NewErrorScreenCTABehavior.mp4

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	49a1560
	Direct Download	woocommerce-wear-prototype-build-pr13389-49a1560.apk

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	49a1560
	Direct Download	woocommerce-prototype-build-pr13389-49a1560.apk

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 20.51282% with 31 lines in your changes missing coverage. Please review.

Project coverage is 41.22%. Comparing base (ca38ed6) to head (49a1560).
Report is 318 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...droid/ui/products/images/ProductImagesViewModel.kt	9.09%	10 Missing ⚠️
...m/woocommerce/android/ui/base/UIMessageResolver.kt	0.00%	7 Missing ⚠️
...ommerce/android/ui/media/MediaFileUploadHandler.kt	0.00%	7 Missing ⚠️
.../android/ui/media/MediaUploadErrorListViewModel.kt	20.00%	4 Missing ⚠️
...roid/ui/products/details/ProductDetailViewModel.kt	66.66%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #13389      +/-   ##
============================================
- Coverage     41.23%   41.22%   -0.01%     
  Complexity     6548     6548              
============================================
  Files          1326     1326              
  Lines         77731    77754      +23     
  Branches      10706    10713       +7     
============================================
+ Hits          32049    32053       +4     
- Misses        42836    42855      +19     
  Partials       2846     2846              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JorgeMucientes]

Hey @hafizrahman I've tweaked your implementation a bit. I'd appreciate if you could test out the changes and let me know what you think 🙏🏼

[hafizrahman]

@JorgeMucientes The testing description point 12 says "Once it fails again, close product detail and reopen it. The "View recent upload failures" should be gone". But from the PR description and code, it will only be gone if there's unsaved changes/current upload then merchants agree to go back.

Otherwise, when going back from details to list when there's upload error but no new changes, then back to details again, the error will persist. Like in video below:

Screen.Recording.2025-01-31.at.09.20.42.mov

In other words, I think the code is correct, but the testing description need updating. Does that sound right?

---

Overall though I think the code looks good, thanks for adding the tweaks with handling / clearing up errors. I added a commit d7c0eef to tweak button placement on product details, so they look like this now:

Dark	Light

I think for iteration 2 we can look at improving the button design if needed, but usability-wise I think it's OK for now.

[JorgeMucientes]

Thanks for the careful review @hafizrahman.

In other words, I think the code is correct, but the testing description needs updating. Does that sound right?
You're right. I've updated the instructions accordingly.

Also, agree with the added UI change to the upload error CTA 👍🏼