-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android SDK] Edge-to-edge to WooLogViewer activity #13372
[Android SDK] Edge-to-edge to WooLogViewer activity #13372
Conversation
} | ||
) | ||
} | ||
Box( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not really a nice way of doing this, but it looks like due to usage of the theme that has background that don't match the toolbar, the status bar would have a different color, which kills "edge-to-edge" filling
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b8b9e06
into
13270-android-sdk-update-target-sdk-to-35
Description
Adds insets as padding. Make the color of the whole top part the same color as toolbar
Steps to reproduce
More -> Settings -> Help -> View logs
Testing information
Notice that it both dark and light modes looks as edge to edge. Both on android 35 or lower devices
The tests that have been performed
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: