Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android SDK] Edge-to-edge to WooLogViewer activity #13372

Merged

Conversation

kidinov
Copy link
Contributor

@kidinov kidinov commented Jan 22, 2025

Description

Adds insets as padding. Make the color of the whole top part the same color as toolbar

Steps to reproduce

More -> Settings -> Help -> View logs

Testing information

Notice that it both dark and light modes looks as edge to edge. Both on android 35 or lower devices

The tests that have been performed

Images/gif

image image
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@kidinov kidinov added this to the 21.5 milestone Jan 22, 2025
@kidinov kidinov requested a review from AnirudhBhat January 22, 2025 10:46
}
)
}
Box(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not really a nice way of doing this, but it looks like due to usage of the theme that has background that don't match the toolbar, the status bar would have a different color, which kills "edge-to-edge" filling

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 22, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit9807a6a
Direct Downloadwoocommerce-wear-prototype-build-pr13372-9807a6a.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 22, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit9807a6a
Direct Downloadwoocommerce-prototype-build-pr13372-9807a6a.apk

@wpmobilebot wpmobilebot modified the milestones: 21.5, 21.6 Jan 24, 2025
@wpmobilebot
Copy link
Collaborator

Version 21.5 has now entered code-freeze, so the milestone of this PR has been updated to 21.6.

@AnirudhBhat AnirudhBhat self-assigned this Jan 28, 2025
Copy link
Contributor

@AnirudhBhat AnirudhBhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@kidinov kidinov merged commit b8b9e06 into 13270-android-sdk-update-target-sdk-to-35 Jan 29, 2025
17 of 22 checks passed
@kidinov kidinov deleted the edge-to-edge-woologviewer branch January 29, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants