Separate settings view mode from ContactInformation
#1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into two "pages" components, for phone and address settings. Implements part of #962 (comment).
Implements part of #962 (comment)
eason9487
approved these changes
Sep 30, 2021
Comment on lines
+2
to
+5
| // We could've used `StoreAddressCard'`s selectors, | ||
| // but the elements are wrapped with `<FlexItem>`, | ||
| // which does not have accessible semantic selector. | ||
| // So we have to rely on `<AccountCard>`'s internal implementation details. |
There was a problem hiding this comment.
💅
What about adding className onto these components?
There was a problem hiding this comment.
I proposed that with a bit more structured & generic way in #1030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚠ this PR requires #1025
Changes proposed in this Pull Request:
settingsview mode fromContactInformationinto two "pages" components, for phone and address settings.
Implements part of #962 (comment).
Screenshots:
/wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fsetup-mc/wp-admin/admin.php?page=wc-admin&subpath=%2Fedit-phone-number&path=%2Fgoogle%2Fsettings/wp-admin/admin.php?page=wc-admin&subpath=%2Fedit-store-address&path=%2Fgoogle%2FsettingsDetailed test instructions:
Onboarding
Settings
Go to the GLA settings page
Click Phone number "Edit"
See if the UI looks like in the latest Figma designs
Check if verifying a phone number works as before
Go to the GLA settings page
Click Store address "Edit"
See if the UI looks like in the latest Figma designs
Check if verifying saving the address works as before.
Changelog entry
Additional notes: