-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ada binding: add support for PSK client callback #8332
base: master
Are you sure you want to change the base?
Conversation
Tested with: `wolfSSL/wolfssl-examples/psk/server-psk.c` after changing `DTLSv1_3_Client_Method` to `DTLSv1_2_Client_Method` to comply with the server example.
Can one of the admins verify this patch? |
Hi @mgrojo , Thank you for your code contribution. In order to consider this we will need to have an agreement on file. Can you please email support at wolfssl dot com and reference this PR requesting a contributor agreement. Please include information about your location and current project. Thanks, |
Hi @mgrojo , Your contributor agreement has been approved. We will review these changes and provide feedback shortly. Okay to test Thanks, |
Tagging some of our Ada contributors for awareness : @joakim-strandberg @dalybrown @Irvise |
- Add comments for the PSK value in the example. - Add runtime argument for executing the PSK test. - Warn user that their callback implementation can't be in the SPARK subset.
Retest this please: "FIPSv2-regression" failure. |
Where can I see that failure? Nevertheless, it's probably unrelated, since these are only additions. Could it be the same case as I have found here: #5579 (comment)?
|
That's from our internal Jenkins and not related to your changes. So just ignore for now. |
Description
This adds support in the Ada binding for
wolfSSL_set_psk_client_callback
.Testing
Tested with:
wolfSSL/wolfssl-examples/psk/server-psk.c
after changing
DTLSv1_3_Client_Method
toDTLSv1_2_Client_Method
to comply with the server example.Checklist