Podman Support and Shellcheck #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not notice this pull request; but I don't see that your fixes are correct. It looks like it defaults to podman and you have to set something to make it work with docker. And the base repo the pull is from changes. If you still care I would try a version that defaulted to docker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really like your project but I'm using Podman, a drop-in replacement for docker. I changed the scripts in
./bin/to still use docker by default but enable podman support by setting$CONTAINER_ENGINE=podman.Secondly I ran Shellcheck, a linter for shell scripts, and fixed all warnings which were mostly just
SC2086.So all in all this does not change anything that is already in production but just adds the option to use Podman.