Stop using tempfile.NamedTemporaryFile in test_cached_download.py

wkentaro · Feb 2, 2024 · 15ee504 · 15ee504
1 parent 44a7ca5
commit 15ee504
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/gdown/cached_download.py b/gdown/cached_download.py
@@ -181,8 +181,6 @@ def _assert_filehash(path, hash, quiet=False, blocksize=None):
     hash_actual = _compute_filehash(path=path, algorithm=algorithm)
 
     if hash_actual == hash:
-        if not quiet:
-            print(f"File hash matches: {path!r} == {hash!r}", file=sys.stderr)
         return True
 
     raise AssertionError(

diff --git a/tests/test_cached_download.py b/tests/test_cached_download.py
@@ -1,13 +1,15 @@
+import os
 import tempfile
 
 import gdown
 
 
 def _cached_download(**kwargs):
     url = "https://drive.google.com/uc?id=0B9P1L--7Wd2vU3VUVlFnbTgtS2c"
-    with tempfile.NamedTemporaryFile() as f:
-        for _ in range(2):
-            gdown.cached_download(url=url, path=f.name, **kwargs)
+    path = tempfile.mktemp()
+    for _ in range(2):
+        gdown.cached_download(url=url, path=path, **kwargs)
+    os.remove(path)
 
 
 def test_cached_download_md5():