Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pac): Added Power Platform CLI completion spec #2168

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

rajyraman
Copy link
Contributor

Power Platform CLI is a command line tool from Microsoft https://www.nuget.org/packages/Microsoft.PowerApps.CLI/

@withfig-bot
Copy link
Collaborator

withfig-bot commented Nov 11, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@rajyraman
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@withfig-bot
Copy link
Collaborator

Overview

src/pac.ts:

Info:

@withfig-bot
Copy link
Collaborator

Hello @rajyraman,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

withfig-bot added a commit that referenced this pull request Nov 11, 2023
@rajyraman
Copy link
Contributor Author

@grant0417 @mschrage - Regarding linting errors the autocomplete JSON is autogenerated based on Microsoft's JSON for pac in pac.doc.json

https://nuget.info/packages/Microsoft.PowerApps.CLI/1.29.6

image

@grant0417
Copy link
Member

You can run npm run lint:fix which should resolve the issues. Otherwise you can add an eslint ignore to ignore the lints for the file.

@rajyraman
Copy link
Contributor Author

@grant0417 - New pac version was released after the PR. I have updated the spec and also ran lint as you suggested.

Copy link
Member

@grant0417 grant0417 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contrib!

@grant0417 grant0417 merged commit 5c7cf56 into withfig:master Dec 1, 2023
4 checks passed
@withfig withfig locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants