Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure showcase titles are not "Just a moment..." #1365

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Jan 6, 2025

As discussed on Discord, this PR ensures that the showcase titles are not "Just a moment..." by enforcing that in the showcase collection schema.

This title usually means that fetching infos was blocked, e.g. on Cloudflare hosted sites and that the title will need to be updated manually.

Happy to discuss the wording of the error message as usual.

Test Checklist

I have tested this PR by building the website locally to ensure no entries have the title "Just a moment...".

I also changed the title of one of the showcase entries to "Just a moment..." to ensure that the build fails.

image

Browser Test Checklist

I have tested this PR on at least three of the following browsers:

  • Chrome / Chromium
  • Firefox
  • Android Firefox
  • Safari
  • iOS Safari

This change does not affect the browser output.

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for astro-www-2 ready!

Name Link
🔨 Latest commit 26cfa71
🔍 Latest deploy log https://app.netlify.com/sites/astro-www-2/deploys/677c1c0db993540008ced032
😎 Deploy Preview https://deploy-preview-1365--astro-www-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
5 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 94 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this! And I think the error message looks perfect — clearly indicates the issue to me.

@HiDeoo HiDeoo merged commit e5d4525 into main Jan 6, 2025
6 checks passed
@HiDeoo HiDeoo deleted the hd-feat-showcase-title-prevent-loading branch January 6, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants