Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Astro 4.7 article #1078

Merged
merged 4 commits into from
Apr 25, 2024
Merged

feat: Astro 4.7 article #1078

merged 4 commits into from
Apr 25, 2024

Conversation

Princesseuh
Copy link
Member

No description provided.

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
astro-build ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 3:20pm

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @Princesseuh ! I left some suggestions for you to consider, and otherwise in general, I might not use the word "major" here since it has another meaning.

(Specifically, we did remove and change a lot of the text in the Dev Toolbar App API page, so it could look like we really did do breaking changes.)

src/content/blog/astro-470.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-470.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-470.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-470.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-470.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-470.mdx Show resolved Hide resolved
Co-authored-by: Sarah Rainsberger <[email protected]>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Princesseuh , approving the text as is, but have left some options in case you decided you didn't want to use the word "major" here. Some are fun! Some are more boring. You get to choose.

@Princesseuh Princesseuh merged commit 60a4cac into main Apr 25, 2024
4 checks passed
@Princesseuh Princesseuh deleted the feat/astro-470 branch April 25, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants