new ci workflows (#1041)

Adds the CI workflows to run on PRs, also organizes imports and other small lint/typecheck fixes. After this merges, I'll add the actual merge requirement rules in the repo

.github/actions/install/action.yml → .github/actions/setup-node-pnpm/action.yml

@@ -1,18 +1,18 @@
-name: Install Tools & Dependencies
-description: Installs pnpm, Node.js & package dependencies
+name: Setup Node.js & pnpm
+description: Setup Node.js and pnpm and install dependencies
 
 runs:
   using: composite
   steps:
-    - name: Setup PNPM
+    - name: Setup pnpm
       uses: pnpm/action-setup@v3
 
-    - name: Setup Node
+    - name: Setup Node.js
       uses: actions/setup-node@v4
       with:
         node-version: 18
         cache: pnpm
 
     - name: Install dependencies
-      run: pnpm install
       shell: bash
+      run: pnpm install

.github/workflows/blog.yml

@@ -10,10 +10,8 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Setup Node
-        uses: actions/setup-node@v4
-        with:
-          node-version: 16
+      - name: Setup Node.js & install dependencies
+        uses: ./.github/actions/setup-node-pnpm
 
       - name: Draft minor release blog post
         run: node scripts/draft-release-post.mjs

.github/workflows/format-main.yml

@@ -0,0 +1,33 @@
+name: Format main branch
+
+on:
+  push:
+    branches:
+      - main
+  workflow_dispatch:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  format:
+    runs-on: ubuntu-latest
+    env:
+      NODE_OPTIONS: "--max_old_space_size=4096"
+    permissions:
+      contents: write
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js & install dependencies
+        uses: ./.github/actions/setup-node-pnpm
+
+      - name: Format
+        run: pnpm run format
+
+      - name: Commit changes
+        uses: stefanzweifel/git-auto-commit-action@v5
+        with:
+          commit_message: "[ci] format"

.github/workflows/nightly.yaml

@@ -14,8 +14,8 @@ jobs:
       - name: Check out code using Git
         uses: actions/checkout@v4
 
-      - name: Install Tools & Dependencies
-        uses: ./.github/actions/install
+      - name: Setup Node.js & install dependencies
+        uses: ./.github/actions/setup-node-pnpm
 
       - name: Search NPM for new and deprecated integrations
         run: pnpm run update:integrations

.github/workflows/pr-checks.yaml

@@ -0,0 +1,28 @@
+name: PR Checks
+
+on:
+  pull_request:
+  workflow_dispatch:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        script: [lint, typecheck]
+      fail-fast: false
+    env:
+      NODE_OPTIONS: "--max_old_space_size=4096"
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js & install dependencies
+        uses: ./.github/actions/setup-node-pnpm
+
+      - name: Run ${{ matrix.script }}
+        run: pnpm run ${{ matrix.script }}

.github/workflows/weekly.yaml

@@ -14,8 +14,8 @@ jobs:
       - name: Check out code using Git
         uses: actions/checkout@v4
 
-      - name: Install Tools & Dependencies
-        uses: ./.github/actions/install
+      - name: Setup Node.js & install dependencies
+        uses: ./.github/actions/setup-node-pnpm
 
       - name: Search NPM for new and deprecated integrations
         run: pnpm run update:integrations --unsafe

scripts/migrate-integrations.mjs

@@ -1,6 +1,6 @@
-import yaml from "json-to-pretty-yaml";
 import fs from "node:fs";
 import path from "node:path";
+import yaml from "json-to-pretty-yaml";
 import slugify from "slugify";
 
 function main() {

scripts/update-integrations.mjs

@@ -1,8 +1,8 @@
-import matter from "gray-matter";
-import yaml from "json-to-pretty-yaml";
 import fs from "node:fs";
 import path from "node:path";
 import { fileURLToPath } from "node:url";
+import matter from "gray-matter";
+import yaml from "json-to-pretty-yaml";
 import slugify from "slugify";
 import glob from "tiny-glob";
 import {

src/components/Collapse.tsx

@@ -1,5 +1,5 @@
 import clsx from "clsx";
-import { createEffect, createSignal, onCleanup, onMount, splitProps, type JSX } from "solid-js";
+import { type JSX, createEffect, createSignal, onCleanup, onMount, splitProps } from "solid-js";
 
 export default function Collapse(
 	props: { children: JSX.Element; isOpen: boolean } & JSX.IntrinsicElements["div"],

src/components/form/DropdownMultiSelect.tsx

@@ -1,4 +1,4 @@
-import { createSignal, For, type JSX } from "solid-js";
+import { For, type JSX, createSignal } from "solid-js";
 import { getElement, getElements } from "~/helpers/dom.js";
 import ChevronIcon from "~/icons/ChevronIcon.jsx";
 import CheckCircleIcon from "~/icons/integrations/CheckCircleIcon.jsx";

src/helpers/discord.ts

@@ -1,5 +1,5 @@
-import fetch, { FormData, Headers, type Response } from "node-fetch";
 import { posix } from "node:path";
+import fetch, { FormData, Headers, type Response } from "node-fetch";
 import { z } from "zod";
 
 const discordMessageAttachmentSchema = z.object({

src/helpers/integrations.ts

@@ -1,4 +1,4 @@
-import { getCollection, type CollectionEntry } from "astro:content";
+import { type CollectionEntry, getCollection } from "astro:content";
 import { IntegrationCategories } from "~/content/config.js";
 import type { MapKeys } from "./types.ts";
 

src/icons/integrations/index.ts

@@ -26,13 +26,15 @@ const categoryIcons = new Map([
 ]);
 
 export function iconForCategory(category: string) {
-	return randomFromArray(categoryIcons.get(category) ?? categoryIcons.get("other") ?? []);
+	return (
+		randomFromArray(categoryIcons.get(category) ?? categoryIcons.get("other") ?? []) ?? PuzzleIcon
+	);
 }
 
 export function iconForIntegration(integration: CollectionEntry<"integrations">) {
 	const icons = integration.data.categories.flatMap(
 		(category) => categoryIcons.get(category) ?? [],
 	);
 
-	return randomFromArray(icons);
+	return randomFromArray(icons) ?? PuzzleIcon;
 }

src/pages/_components/ExampleShowcase.tsx

@@ -1,5 +1,5 @@
 import clsx from "clsx";
-import { createEffect, createSignal, For } from "solid-js";
+import { For, createEffect, createSignal } from "solid-js";
 import Collapse from "~/components/Collapse.jsx";
 import { positiveMod } from "~/helpers/math.js";
 import agenciesImage from "../_assets/example-agencies.png";

src/pages/api/showcase.json.ts

@@ -1,5 +1,5 @@
-import type { APIRoute } from "astro";
 import { getCollection } from "astro:content";
+import type { APIRoute } from "astro";
 
 export const GET: APIRoute = async () => {
 	const showcase = await getCollection("showcase");

src/pages/api/v1/integrations/[...page].ts

@@ -2,8 +2,8 @@ import type { APIRoute } from "astro";
 import { integrations as LAST_MODIFIED } from "~/data/last-modified.json";
 import {
 	getFilteredIntegrations,
-	validateCategories,
 	validCategories,
+	validateCategories,
 } from "~/helpers/integrations.ts";
 import { paginate } from "~/helpers/paginate.ts";
 

src/pages/rss.xml.ts

@@ -1,6 +1,6 @@
+import { getCollection } from "astro:content";
 import rss from "@astrojs/rss";
 import type { APIRoute } from "astro";
-import { getCollection } from "astro:content";
 
 function sortPosts(a: { data: { publishDate: Date } }, b: { data: { publishDate: Date } }) {
 	return Number(b.data.publishDate) - Number(a.data.publishDate);

src/pages/themes/submit/_components/ThemeImageUploader.tsx

@@ -1,4 +1,4 @@
-import { createSignal, For, onMount, Show } from "solid-js";
+import { For, Show, createSignal, onMount } from "solid-js";
 import type { JSX } from "solid-js/jsx-runtime";
 import FileUploadIcon from "~/icons/FileUploadIcon.jsx";
 

tsconfig.json

@@ -8,6 +8,5 @@
 		"jsx": "preserve",
 		"jsxImportSource": "solid-js"
 	},
-	"include": ["**/*", ".eslintrc.cjs"],
 	"exclude": ["node_modules", "dist", ".vercel", "public"]
 }