Skip to content

Commit

Permalink
chore: remove e-mail tags (#970)
Browse files Browse the repository at this point in the history
  • Loading branch information
ElianCodes authored Jan 26, 2024
1 parent 027d4d5 commit ab620dc
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/components/Footer.astro
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ const socialLinks = siteInfo.socialLinks
aria-label="Secondary"
class="flex flex-col items-start justify-between gap-12 py-8 sm:flex-row-reverse md:py-12"
>
<NewsLetterSignup tag="footer" />
<NewsLetterSignup />
<div class="grid grid-cols-2 gap-12 sm:flex sm:flex-wrap sm:gap-16 lg:gap-20">
{
groups.map(({ title, items }, index) => (
Expand Down
8 changes: 3 additions & 5 deletions src/components/NewsLetterSignup.astro
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
interface Props {
skipText?: boolean
tag?: string
}
const { skipText = false, tag } = Astro.props
const { skipText = false } = Astro.props
---

<div class={`${skipText ? "mx-auto" : ""} flex flex-col self-center md:max-w-sm`}>
Expand All @@ -21,9 +21,7 @@ const { skipText = false, tag } = Astro.props
action="https://buttondown.email/api/emails/embed-subscribe/withastro"
method="post"
target="popupwindow"
onsubmit={`window.open('https://buttondown.email/withastro${
tag ? `?tag=${tag}` : ``
}', 'popupwindow')`}
onsubmit="window.open('https://buttondown.email/withastro', 'popupwindow')"
class="flex flex-col justify-between"
>
<input
Expand Down
2 changes: 1 addition & 1 deletion src/pages/newsletter/signup.astro
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import Houston from "../_assets/houston_peep.webp"
Enter your email to stay in the know with the latest updates from Astro.
</p>
<div class="w-full">
<NewsLetterSignup tag="page" skipText={true} />
<NewsLetterSignup skipText={true} />
</div>
</div>
<div class="flex w-full justify-center overflow-clip">
Expand Down

0 comments on commit ab620dc

Please sign in to comment.