Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional allocations #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Additional allocations #8

wants to merge 1 commit into from

Conversation

mason-rogers
Copy link
Contributor

Huge thanks @snags141 for laying the foundation of this feature

Carrying on from his work, it has been improved by fixing a couple bugs/making bits more efficient

  • The original PR did not pre-check node resource eligibility, so when using additional ports it was able to pick a node which did not have room for the server -> leading to an error
    • Now, we pull eligible nodes for the given location first before we check allocations (through an endpoint newly made for this purpose)
  • A new endpoint was introduced in WISP to only pull available allocations, rather than fetching all of them and filtering out assigned ones - ultimately more efficient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant