Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Debounce on conversation click to avoid maximum update depth exceeded error (WPB-11955) #18690

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

thisisamir98
Copy link
Contributor

@thisisamir98 thisisamir98 commented Jan 29, 2025

BugWPB-11955 [Web] Webapp crashes when quickly switching conversations

Description

when clicking too fast to switch conversations we update the state of the react too many times we end up with a Maximum update depth exceeded react error.

https://react.dev/errors/185

To avoid this a debounce mechanism is added to the conversation onClick handler.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes missing coverage. Please review.

Project coverage is 45.98%. Comparing base (b29309f) to head (d285b4f).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #18690   +/-   ##
=======================================
  Coverage   45.98%   45.98%           
=======================================
  Files         894      894           
  Lines       27459    27461    +2     
  Branches     6201     6201           
=======================================
+ Hits        12627    12628    +1     
- Misses      13266    13267    +1     
  Partials     1566     1566           

@thisisamir98 thisisamir98 merged commit cd92860 into dev Jan 29, 2025
16 checks passed
@thisisamir98 thisisamir98 deleted the fix-11955 branch January 29, 2025 12:25
@paulwire paulwire added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants