Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve virtual rendering focus issues (WPB-15154) #18688

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

thisisamir98
Copy link
Contributor

@thisisamir98 thisisamir98 commented Jan 28, 2025

TaskWPB-15154 [Web] Improve loading of conversation list by only loading what is visible in viewport

Description

  • changed align behavior of scrollToIndex of rowVirtualizer to auto to avoid always bringing the conversation in center even in cases they are already visible
  • removed useEffect for focusing as it was causing unexpected focus jumping behavior and it had no use case when opening a folder

@thisisamir98 thisisamir98 requested review from otto-the-bot and a team as code owners January 28, 2025 12:33
@echoes-hq echoes-hq bot added the echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. label Jan 28, 2025
Copy link
Contributor

@przemvs przemvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.95%. Comparing base (c4599fa) to head (a3cd9a7).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18688      +/-   ##
==========================================
- Coverage   45.98%   45.95%   -0.03%     
==========================================
  Files         894      894              
  Lines       27405    27411       +6     
  Branches     6187     6188       +1     
==========================================
- Hits        12601    12596       -5     
- Misses      13239    13250      +11     
  Partials     1565     1565              

@thisisamir98 thisisamir98 merged commit e7ce5b2 into dev Jan 28, 2025
16 checks passed
@thisisamir98 thisisamir98 deleted the fix-WPB-15154 branch January 28, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants