Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FailedToAddUsersMessage): fix styles for messageDetails [WPB-15334] #18668

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

dariaoldenburg
Copy link
Contributor

@dariaoldenburg dariaoldenburg commented Jan 24, 2025

BugWPB-15334 [Web] Added participants description shifted when created a group after MLS migration

Notes

I asked the designer about the spacings. I have her approval :)

Screenshots/Screencast (for UI changes)

Please ignore the order of the messages in the screenshot (it's just a mock)

Screenshot 2025-01-24 at 22 14 40

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@dariaoldenburg dariaoldenburg requested review from otto-the-bot and a team as code owners January 24, 2025 21:43
@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 24, 2025
@dariaoldenburg dariaoldenburg changed the title fix(FailedToAddUsersMessage): fix styles for messageDetails fix(FailedToAddUsersMessage): fix styles for messageDetails [WPB-15334] Jan 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.98%. Comparing base (ba0de1b) to head (1cb3944).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18668      +/-   ##
==========================================
+ Coverage   45.97%   45.98%   +0.01%     
==========================================
  Files         894      894              
  Lines       27392    27392              
  Branches     6181     6181              
==========================================
+ Hits        12594    12597       +3     
+ Misses      13234    13231       -3     
  Partials     1564     1564              

@dariaoldenburg dariaoldenburg force-pushed the fix/WPB-15334-failedToAddUsersMessage-alignment branch from b78c205 to 18a810a Compare January 26, 2025 21:43
@dariaoldenburg dariaoldenburg force-pushed the fix/WPB-15334-failedToAddUsersMessage-alignment branch from 18a810a to 1cb3944 Compare January 27, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants