feat(RichTextEditor): enhanced look, link/quote/code block buttons [WPB-15264] #18643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…redundant shiftKey check
…k node management
…ut for better usability
…k state management
…e url sanitization logic
…link node handling logic
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18643 +/- ##
==========================================
- Coverage 46.22% 45.96% -0.26%
==========================================
Files 880 894 +14
Lines 27109 27347 +238
Branches 6118 6170 +52
==========================================
+ Hits 12532 12571 +39
- Misses 13017 13213 +196
- Partials 1560 1563 +3 |
przemvs
reviewed
Jan 23, 2025
src/script/components/InputBar/components/InputBarControls/ControlButtons.tsx
Outdated
Show resolved
Hide resolved
przemvs
reviewed
Jan 23, 2025
src/script/components/InputBar/components/InputBarControls/ControlButtons.tsx
Outdated
Show resolved
Hide resolved
przemvs
reviewed
Jan 23, 2025
src/script/components/InputBar/components/InputBarControls/ControlButtons.tsx
Outdated
Show resolved
Hide resolved
przemvs
reviewed
Jan 23, 2025
src/script/components/InputBar/components/InputBarControls/ControlButtons.tsx
Outdated
Show resolved
Hide resolved
przemvs
reviewed
Jan 23, 2025
src/script/components/InputBar/components/InputBarControls/GiphyButton/GiphyButton.tsx
Outdated
Show resolved
Hide resolved
przemvs
reviewed
Jan 23, 2025
...onents/InputBar/components/RichTextEditor/components/FormatToolbar/LinkDialog/LinkDialog.tsx
Show resolved
Hide resolved
przemvs
reviewed
Jan 23, 2025
...onents/InputBar/components/RichTextEditor/components/FormatToolbar/LinkDialog/LinkDialog.tsx
Outdated
Show resolved
Hide resolved
… values for isEditing
przemvs
reviewed
Jan 23, 2025
...ents/RichTextEditor/components/FormatToolbar/useLinkState/getSelectedNode/getSelectedNode.ts
Outdated
Show resolved
Hide resolved
przemvs
reviewed
Jan 23, 2025
...ents/RichTextEditor/components/FormatToolbar/useLinkState/getSelectedNode/getSelectedNode.ts
Outdated
Show resolved
Hide resolved
przemvs
reviewed
Jan 23, 2025
src/script/components/InputBar/components/RichTextEditor/plugins/PastePlugin/PastePlugin.tsx
Outdated
Show resolved
Hide resolved
…ng selection properties
przemvs
reviewed
Jan 23, 2025
…ted content based on preview mode
src/script/components/InputBar/components/InputBarControls/ControlButtons.tsx
Outdated
Show resolved
Hide resolved
e-maad
reviewed
Jan 23, 2025
src/script/components/InputBar/components/InputBarControls/ControlButtons.tsx
Outdated
Show resolved
Hide resolved
| })} | ||
| type="button" | ||
| onClick={onClick} | ||
| title={isActive ? t('tooltipConversationHideFormatting') : t('tooltipConversationShowFormatting')} | ||
| aria-label={isActive ? t('tooltipConversationHideFormatting') : t('tooltipConversationShowFormatting')} | ||
| data-uie-name="format-text" | ||
| > | ||
| <Icon.MarkdownIcon /> | ||
| <Icon.MarkdownIcon width={14} height={14} /> |
There was a problem hiding this comment.
Should we make the icon size responsive using a relative unit (rem)?
There was a problem hiding this comment.
Not really, I don't see a reason to do that
| </div> | ||
| <form css={formStyles} onSubmit={handleSubmit} noValidate> | ||
| <Input | ||
| ref={textInputRef} |
There was a problem hiding this comment.
Is it possible to use callback here to avoid timeout in in useEffect?
There was a problem hiding this comment.
I don't think so, the timeout is actually needed there, I added a comment next to it why it's there
| value={formData.text} | ||
| markInvalid={isSubmitted && !!errors.text} | ||
| onChange={event => handleInputChange({event, field: 'text'})} | ||
| error={!!isSubmitted && !!errors.text ? <ErrorMessage>{errors.text}</ErrorMessage> : undefined} |
There was a problem hiding this comment.
Is this possible?
Suggested change
| error={!!isSubmitted && !!errors.text ? <ErrorMessage>{errors.text}</ErrorMessage> : undefined} | |
| error={!!isSubmitted && !!errors.text && <ErrorMessage>{errors.text}</ErrorMessage>} |
There was a problem hiding this comment.
I would need to refactor it somehow because it's throwing an error:
Type 'false | Element' is not assignable to type 'ReactElement<any, string | JSXElementConstructor<any>> | undefined'.
Type 'boolean' is not assignable to type 'ReactElement<any, string | JSXElementConstructor<any>>'.
It's reasonable, when !!isSubmitted && !!errors.url will be false:
- When isSubmitted is false
- When errors.url is undefined/null/empty
|
paulwire
added
the
echoes: product-roadmap/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's changed:
Adding link:
adding-link.mov
Editing link:
editing-link.mov
Auto link:
auto-link.mov
Link validation:
link-validation.mov
Inserting blockquote and code blocks:
blockquote-code-block.mov
Theme changes & edit a message:
theme.mov
Checklist