Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restrict delete group option to admins in the creator's team [WPB-15293] #18642

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

waseemansar
Copy link
Contributor

@waseemansar waseemansar commented Jan 22, 2025

BugWPB-15293 [Web] Only group admins, that are in the same team as the group creator, should see the delete group option

Description

Fixes the issue where the "Delete group" option is visible to group admins who are not part of the same team as the group creator.

Screenshots/Screencast (for UI changes)

Before

issue

After

fix

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@waseemansar waseemansar requested review from otto-the-bot and a team as code owners January 22, 2025 08:40
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 22, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.24%. Comparing base (1c9a619) to head (d78fd6b).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #18642   +/-   ##
=======================================
  Coverage   46.24%   46.24%           
=======================================
  Files         880      880           
  Lines       27109    27109           
  Branches     6118     6118           
=======================================
  Hits        12536    12536           
  Misses      13014    13014           
  Partials     1559     1559           

@waseemansar waseemansar merged commit da73275 into dev Jan 22, 2025
15 of 16 checks passed
@waseemansar waseemansar deleted the fix/delete-group-option-WPB-15293 branch January 22, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 👕 size: XS type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants