Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace underscore debounce with use-debounce #18586

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

olafsulich
Copy link
Contributor

@olafsulich olafsulich commented Jan 14, 2025

Description

Because of introducing use-debounce in #18574, I have done a little refactoring, completely removing our internal useDebounce and replacing it with the code from the library.

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

Copy link

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 54 lines in your changes missing coverage. Please review.

Project coverage is 46.22%. Comparing base (549fed0) to head (4e8ada7).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18586      +/-   ##
==========================================
- Coverage   46.23%   46.22%   -0.02%     
==========================================
  Files         880      879       -1     
  Lines       26963    26971       +8     
  Branches     6089     6090       +1     
==========================================
- Hits        12467    12466       -1     
- Misses      12944    12953       +9     
  Partials     1552     1552              

@olafsulich olafsulich marked this pull request as ready for review January 14, 2025 11:06
@olafsulich olafsulich requested review from otto-the-bot and a team as code owners January 14, 2025 11:06
@olafsulich olafsulich merged commit bff2faf into dev Jan 15, 2025
18 checks passed
@olafsulich olafsulich deleted the refactor/debounce branch January 15, 2025 08:22
@paulwire paulwire added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 👕 size: L type: refactoring 🛠
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants