Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix: do not pass files to debug logs after validating metadata [WPB-15317] #18580

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Jan 13, 2025

TaskWPB-15317 [Web] Cannot restore prod backup to current edge webapp

Description

Electron appears to be running into heap size issues because of JSON.stringify of the entire passed files with this debug logs.

We want to pinpoint the issue by removing the passed files from the logs

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@V-Gira V-Gira merged commit 9ce008c into dev Jan 13, 2025
17 of 20 checks passed
@V-Gira V-Gira deleted the v/investigate-logger-issue branch January 13, 2025 11:45
@paulwire paulwire added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. 👕 size: XS type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants