fix: Clean up connections when user joins team (WPB-15263) #18579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the implementation of converting personal users to team users it turned out we need to clear any previous pending connection user A could possibly have with user B before user B joined user A's team.
in this PR we use
user.update
event to find out when a user has joined our team then:If the user is our self user -> we delete all pending connections old previous - connections that are not accepted - with the new team members we find.
If the user is someone else -> we try to find if we have a pending old connection with them and delete it.
notes: