Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Show drafted message [WPB-10991] #18574

Merged
merged 8 commits into from
Jan 14, 2025
Merged

feat: Show drafted message [WPB-10991] #18574

merged 8 commits into from
Jan 14, 2025

Conversation

przemvs
Copy link
Contributor

@przemvs przemvs commented Jan 9, 2025 •
edited by waseemansar
Loading

TaskWPB-10991 [Web] Show "drafted message" in second line in conversation list

https://wearezeta.atlassian.net/browse/WPB-10991

Description

Showing drafted message while user change tab to inform about there is drafted message.
All another messages/alerts will shown before drafted message.

Screenshots/Screencast (for UI changes)

image

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@przemvs przemvs requested review from otto-the-bot and a team as code owners January 9, 2025 13:35
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.72727% with 15 lines in your changes missing coverage. Please review.

Project coverage is 46.23%. Comparing base (124d517) to head (2b13e22).
Report is 4 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #18574      +/-   ##
==========================================
+ Coverage   46.22%   46.23%   +0.01%     
==========================================
  Files         875      880       +5     
  Lines       26887    26963      +76     
  Branches     6076     6089      +13     
==========================================
+ Hits        12429    12467      +38     
- Misses      12910    12944      +34     
- Partials     1548     1552       +4

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@przemvs przemvs merged commit 549fed0 into dev Jan 14, 2025
16 checks passed
@przemvs przemvs deleted the feat/WPB-10991-show-drafted-message branch January 14, 2025 08:16
@paulwire paulwire added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 14, 2025
@olafsulich olafsulich mentioned this pull request Jan 14, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafsulich olafsulich olafsulich approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 👕 size: L type: feature / request ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@przemvs @codecov-commenter @olafsulich @otto-the-bot @paulwire