Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runfix(pipeline): Let pre-commit pipeline wait until smoke tests are done #18563

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

corodiak
Copy link
Member

@corodiak corodiak commented Jan 7, 2025

Description

The pre-commit pipeline is starting smoke tests before a PR is merged. But the pipeline does not wait for the results of the smoke tests and always reports a success.

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@corodiak corodiak requested a review from V-Gira January 7, 2025 12:50
@corodiak corodiak requested review from otto-the-bot and a team as code owners January 7, 2025 12:50
@V-Gira V-Gira changed the title fix: Let pre-commit pipeline wait until smoke tests are done runfix(pipeline): Let pre-commit pipeline wait until smoke tests are done Jan 7, 2025
@corodiak corodiak force-pushed the fix/wait-for-smoke branch from 5829ecc to 634a48f Compare January 7, 2025 12:57
Copy link

sonarqubecloud bot commented Jan 7, 2025

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.19%. Comparing base (05b0126) to head (634a48f).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18563      +/-   ##
==========================================
- Coverage   46.20%   46.19%   -0.02%     
==========================================
  Files         868      868              
  Lines       26722    26722              
  Branches     6046     6046              
==========================================
- Hits        12348    12343       -5     
- Misses      12833    12836       +3     
- Partials     1541     1543       +2     

@corodiak corodiak merged commit 5c3a308 into dev Jan 7, 2025
16 checks passed
@corodiak corodiak deleted the fix/wait-for-smoke branch January 7, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants