Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "chore: Revert "feat: Handle deleted user names appropriately (WPB-14492)"" #18558

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

thisisamir98
Copy link
Contributor

@thisisamir98 thisisamir98 commented Jan 6, 2025

StoryWPB-14492 [Web] Handling of deleted users

Reverts #18537

@thisisamir98 thisisamir98 requested review from otto-the-bot and a team as code owners January 6, 2025 15:09
@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 6, 2025
Copy link

sonarqubecloud bot commented Jan 6, 2025

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 48.14815% with 14 lines in your changes missing coverage. Please review.

Project coverage is 46.19%. Comparing base (c5aa35d) to head (d01614e).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18558      +/-   ##
==========================================
- Coverage   46.20%   46.19%   -0.01%     
==========================================
  Files         868      868              
  Lines       26711    26720       +9     
  Branches     6043     6046       +3     
==========================================
+ Hits        12342    12344       +2     
- Misses      12829    12835       +6     
- Partials     1540     1541       +1     

@thisisamir98 thisisamir98 merged commit ec2dac9 into dev Jan 7, 2025
16 checks passed
@thisisamir98 thisisamir98 deleted the revert-18537-revert-18521-WPB-14492 branch January 7, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 👕 size: M type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants