Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arrange screen share before the videos [WPB-15036] #18492

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

EnricoSchw
Copy link
Contributor

@EnricoSchw EnricoSchw commented Dec 13, 2024

BugWPB-15036 [Web] User tiles in a call do not reshuffle according to priority (screenshare not bumped)

Description

This PR fix thats user tiles in a call do not reshuffle according to priority (screenshare not bumped)

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.19%. Comparing base (8d2ff03) to head (e3f6b69).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18492      +/-   ##
==========================================
- Coverage   46.20%   46.19%   -0.02%     
==========================================
  Files         868      868              
  Lines       26720    26722       +2     
  Branches     6046     6046              
==========================================
- Hits        12346    12343       -3     
- Misses      12833    12836       +3     
- Partials     1541     1543       +2     

@EnricoSchw EnricoSchw marked this pull request as ready for review January 7, 2025 10:32
@EnricoSchw EnricoSchw requested review from otto-the-bot and a team as code owners January 7, 2025 10:32
Copy link

sonarqubecloud bot commented Jan 7, 2025

@EnricoSchw EnricoSchw merged commit 05b0126 into dev Jan 7, 2025
16 checks passed
@EnricoSchw EnricoSchw deleted the fix/first-screen-share-next-try-WPB-15036 branch January 7, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants