-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename system message - WPB-14824 #2445
fix: rename system message - WPB-14824 #2445
Conversation
Test Results 1 files 1 suites 1m 36s ⏱️ For more details on these failures, see this check. Results for commit 5c4c4c7. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 1093 Passed, 0 Skipped, 1m 44.74s Total Time |
...os-request-strategy/Sources/Request Strategies/Conversation/ConversationEventProcessor.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Issue
When the self user renames a conversation, no system message is shown in his/her conversation.
The reason is that by the time we process the event response of renaming the group, the modifiedKey of the conversation (userDefined) is not present, therefore we don't add the system message.
In the ConversationRequestStrategy the
processEvent
method was calling an async method in a Task that finished after we reset the modifiedKeys in theZMUpstreamModifiedObjectSync
.Solution:
Call the processRenameConverationEvent as a synchronous method so modifiedKeys are reset after the processing is finished.
Testing
Checklist
[WPB-XXX]
.