Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename system message - WPB-14824 #2445

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

netbe
Copy link
Collaborator

@netbe netbe commented Jan 28, 2025

BugWPB-14824 [iOS] No system message if a group name is changed

Issue

When the self user renames a conversation, no system message is shown in his/her conversation.

The reason is that by the time we process the event response of renaming the group, the modifiedKey of the conversation (userDefined) is not present, therefore we don't add the system message.

In the ConversationRequestStrategy the processEvent method was calling an async method in a Task that finished after we reset the modifiedKeys in the ZMUpstreamModifiedObjectSync.

Solution:

Call the processRenameConverationEvent as a synchronous method so modifiedKeys are reset after the processing is finished.

Testing

  1. be admin of a group on iOS device
  2. rename the group
  3. check that the system message is inserted

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 28, 2025
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Test Results

    1 files      1 suites   1m 36s ⏱️
1 192 tests 1 189 ✅ 0 💤 3 ❌
1 192 runs  1 192 ✅ 0 💤 0 ❌

For more details on these failures, see this check.

Results for commit 5c4c4c7.

♻️ This comment has been updated with latest results.

@netbe netbe requested review from a team, samwyndham, caldrian and KaterinaWire and removed request for a team January 28, 2025 20:46
@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 28, 2025

Datadog Report

Branch report: fix/rename-system-message-WPB-14824
Commit report: eea52b0
Test service: wire-ios-mono

✅ 0 Failed, 1093 Passed, 0 Skipped, 1m 44.74s Total Time

Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@netbe netbe enabled auto-merge (squash) January 29, 2025 10:41
@netbe netbe merged commit 27d51b0 into release/cycle-3.116 Jan 29, 2025
9 of 10 checks passed
@netbe netbe deleted the fix/rename-system-message-WPB-14824 branch January 29, 2025 10:52
zenkins pushed a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants