Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip notification when away or busy - WPB-8946 #2444

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-8946 [iOS] I should not get notifications from new groups when my status is set to Away

Issue

The notification extension compares the availability status of the self user with the settings of any conversation's incoming notification. Based on that it is decided if a local notification is scheduled or not.

In the case of a new conversation event, where the conversation is not yet available in the local db, the check doesn't consider the user's availability and always shows the notification.

This PR handles this edge case and decides based on the availability status.

Testing

  • Quit the app
  • From another user create a conversation
  • Depending on the availability settings a notification is shown (for .none, .available) or not (for .busy, .away).

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@github-actions github-actions bot added cherry-pick echoes: unplanned Any work item that isn’t part of the product or technical roadmap. labels Jan 28, 2025
@caldrian caldrian enabled auto-merge January 28, 2025 16:42
Copy link
Contributor Author

Test Results

    1 files      1 suites   2m 18s ⏱️
1 192 tests 1 191 ✅ 0 💤 1 ❌
1 192 runs  1 192 ✅ 0 💤 0 ❌

For more details on these failures, see this check.

Results for commit 2b27a40.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/skip-notification-when-away-WPB-8946-cherry-pick
Commit report: 19f9e6b
Test service: wire-ios-mono

✅ 0 Failed, 1093 Passed, 0 Skipped, 2m 18.58s Total Time

@caldrian caldrian added this pull request to the merge queue Jan 28, 2025
Merged via the queue into develop with commit 33308c6 Jan 28, 2025
11 checks passed
@caldrian caldrian deleted the fix/skip-notification-when-away-WPB-8946-cherry-pick branch January 28, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick echoes: unplanned Any work item that isn’t part of the product or technical roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants