-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash dismissPresentedViewController - WPB-15345 #2442
Merged
netbe
merged 6 commits into
release/cycle-3.116
from
fix/Crash-dismissPresentedViewController-WPB-15345
Jan 29, 2025
Merged
fix: crash dismissPresentedViewController - WPB-15345 #2442
netbe
merged 6 commits into
release/cycle-3.116
from
fix/Crash-dismissPresentedViewController-WPB-15345
Jan 29, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: technical-roadmap
Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt.
label
Jan 28, 2025
Test Results 1 files 9 suites 16s ⏱️ Results for commit daf57da. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 69 Passed, 1 Skipped, 10.84s Total Time |
samwyndham
approved these changes
Jan 29, 2025
KaterinaWire
approved these changes
Jan 29, 2025
netbe
force-pushed
the
fix/Crash-dismissPresentedViewController-WPB-15345
branch
from
January 29, 2025 10:40
9a70c43
to
de7af39
Compare
netbe
force-pushed
the
fix/Crash-dismissPresentedViewController-WPB-15345
branch
from
January 29, 2025 11:10
277f4d2
to
9c36330
Compare
…wController-WPB-15345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: technical-roadmap
Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There's a crash on production app, when we try to dismiss the presentedViewController. It happens because SplitViewController is nil and it's a implicitly unwrapped value.
Testing
I couldn't have it repoduced, so I mainly avoid the crash for now.
Also looking at the stacktrace, I haven't been able to link
openFileMessage(:)
todismissPresentedViewController
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: