Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash dismissPresentedViewController - WPB-15345 #2442

Merged

Conversation

netbe
Copy link
Collaborator

@netbe netbe commented Jan 28, 2025

BugWPB-15345 [iOS] Crash dismissPresentedViewController

Issue

There's a crash on production app, when we try to dismiss the presentedViewController. It happens because SplitViewController is nil and it's a implicitly unwrapped value.

Screenshot 2025-01-28 at 16 31 56

Testing

I couldn't have it repoduced, so I mainly avoid the crash for now.

Also looking at the stacktrace, I haven't been able to link openFileMessage(:) to dismissPresentedViewController


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. label Jan 28, 2025
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Test Results

 1 files   9 suites   16s ⏱️
74 tests 73 ✅ 1 💤 0 ❌
75 runs  74 ✅ 1 💤 0 ❌

Results for commit daf57da.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/Crash-dismissPresentedViewController-WPB-15345
Commit report: 04602f5
Test service: wire-ios-mono

✅ 0 Failed, 69 Passed, 1 Skipped, 10.84s Total Time

@netbe netbe enabled auto-merge (squash) January 29, 2025 10:21
@netbe netbe force-pushed the fix/Crash-dismissPresentedViewController-WPB-15345 branch from 9a70c43 to de7af39 Compare January 29, 2025 10:40
@netbe netbe force-pushed the fix/Crash-dismissPresentedViewController-WPB-15345 branch from 277f4d2 to 9c36330 Compare January 29, 2025 11:10
@netbe netbe merged commit 278b8f1 into release/cycle-3.116 Jan 29, 2025
9 of 10 checks passed
@netbe netbe deleted the fix/Crash-dismissPresentedViewController-WPB-15345 branch January 29, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants