Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash persistent store first - WPB-15476 #2432

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-15476 [iOS] Crash on persistentStore first

Issue

While removing a user from a team a crash occurs while we delete the Account. We receive two events one is a teamMembershipLeave event and the other is a UpdateConverationMemberLeave.

We don't wait for the deleteAccount method to be finished before processing the second event. Then when processing UpdateConverationMemberLeave event, there is a context.saveOrRollback() which will fail because we already removed the persistentStore.

This PR also removes a retain cycle in ProfileHeaderViewController.

Testing

  1. create personal user
  2. invite to team A
  3. remove from team A

App should not crash


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@github-actions github-actions bot added cherry-pick echoes: unplanned Any work item that isn’t part of the product or technical roadmap. labels Jan 27, 2025
@netbe netbe enabled auto-merge January 28, 2025 19:30
Copy link
Contributor Author

Test Results

    3 files      4 suites   8m 14s ⏱️
5 415 tests 5 389 ✅ 26 💤 0 ❌
5 425 runs  5 399 ✅ 26 💤 0 ❌

Results for commit ce42630.

@netbe netbe added this pull request to the merge queue Jan 28, 2025
@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/crash-persistentStoreFirst-cherry-pick
Commit report: 9a9aab4
Test service: wire-ios-mono

✅ 0 Failed, 5142 Passed, 26 Skipped, 4m 48.53s Total Time

Merged via the queue into develop with commit 868841c Jan 28, 2025
13 checks passed
@netbe netbe deleted the fix/crash-persistentStoreFirst-cherry-pick branch January 28, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick echoes: unplanned Any work item that isn’t part of the product or technical roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants