fix: crash persistent store first - WPB-15476 #2432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
Issue
While removing a user from a team a crash occurs while we delete the Account. We receive two events one is a teamMembershipLeave event and the other is a
UpdateConverationMemberLeave
.We don't wait for the deleteAccount method to be finished before processing the second event. Then when processing UpdateConverationMemberLeave event, there is a
context.saveOrRollback()
which will fail because we already removed the persistentStore.This PR also removes a retain cycle in ProfileHeaderViewController.
Testing
App should not crash
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: