Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: close button - WPB-15211 #2388

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Jan 15, 2025

TaskWPB-15211 [iOS] Update the UI for backup export

Issue

This PR moves an icon for the close button from WireDesign to WireReusableUIComponents.
Moreover, the accessibilityLabel argument is replaced by a standard view modifier.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 15, 2025

Datadog Report

Branch report: refactor/close-button-WPB-15211
Commit report: d64d22b
Test service: wire-ios-mono

✅ 0 Failed, 1758 Passed, 27 Skipped, 2m 58.08s Total Time

Copy link
Contributor

Test Results

    2 files     11 suites   3m 6s ⏱️
1 867 tests 1 840 ✅ 27 💤 0 ❌
1 878 runs  1 851 ✅ 27 💤 0 ❌

Results for commit de88a3c.

@@ -22,21 +22,18 @@ import WireDesign
public struct CloseButton: View {

private let action: () -> Void
private let accessibilityLabel: String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the intention here of having the accessibilityLabel as part of the CloseButton came from Agis - the idea was to force us to always use an accessibilityLabel.

I'm OK to remove it, but I can't really think of any cons keeping it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants