-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: close button - WPB-15211 #2388
base: develop
Are you sure you want to change the base?
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 1758 Passed, 27 Skipped, 2m 58.08s Total Time |
Test Results 2 files 11 suites 3m 6s ⏱️ Results for commit de88a3c. |
@@ -22,21 +22,18 @@ import WireDesign | |||
public struct CloseButton: View { | |||
|
|||
private let action: () -> Void | |||
private let accessibilityLabel: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the intention here of having the accessibilityLabel
as part of the CloseButton
came from Agis - the idea was to force us to always use an accessibilityLabel
.
I'm OK to remove it, but I can't really think of any cons keeping it.
Issue
This PR moves an icon for the close button from
WireDesign
toWireReusableUIComponents
.Moreover, the
accessibilityLabel
argument is replaced by a standard view modifier.Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: