Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: generate notification connection request (pending, accepted) - WPB-11659 #2385

Open
wants to merge 1 commit into
base: refactor/generate-notification-connections
Choose a base branch
from

Conversation

jullianm
Copy link
Contributor

@jullianm jullianm commented Jan 13, 2025

TaskWPB-11659 [iOS] Generate UNNotificationContent for new user connection request

Key points

This PR is about generating notification content related to the user connection (pending, accepted) populating the right data in the notification (title, body, sound, category..).

Testing

  • Notification for user connection pending and accepted is correctly populated.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@echoes-hq echoes-hq bot added echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes/initiative: ios-sync-refactoring labels Jan 13, 2025
@jullianm jullianm requested review from johnxnguyen and netbe January 13, 2025 16:17
Copy link
Contributor

Test Results

    3 files      4 suites   4m 24s ⏱️
3 339 tests 3 311 ✅ 28 💤 0 ❌
3 349 runs  3 321 ✅ 28 💤 0 ❌

Results for commit 3c90179.

@datadog-wireapp
Copy link

Datadog Report

Branch report: refactor/generate-notification-connection-request
Commit report: 18b4bff
Test service: wire-ios-mono

✅ 0 Failed, 3200 Passed, 28 Skipped, 2m 20.6s Total Time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: ios-sync-refactoring echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant