Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: generate notification user contact join - WPB-11660 #2383

Open
wants to merge 1 commit into
base: refactor/generate-notification-conversation-member-leave
Choose a base branch
from
Open

refactor: generate notification user contact join - WPB-11660 #2383

wants to merge 1 commit into from
+345 −64

Conversation

jullianm
Copy link
Contributor

@jullianm jullianm commented Jan 13, 2025 •
edited by github-actions bot
Loading

TaskWPB-11660 [iOS] Generate UNNotificationContent for user contact join

Key points

This PR is about generating notification content related to the user join event (connections) populating the right data in the notification (title, body, sound, category..).

Testing

  • Notification for user join is correctly populated.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@echoes-hq echoes-hq bot added echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes/initiative: ios-sync-refactoring labels Jan 13, 2025
@jullianm jullianm requested review from netbe and johnxnguyen January 13, 2025 15:54
@github-actions GitHub Actions
Copy link
Contributor

Test Results

    3 files      4 suites   5m 12s ⏱️
3 339 tests 3 311 ✅ 28 💤 0 ❌
3 349 runs  3 321 ✅ 28 💤 0 ❌

Results for commit 0eb4f18.

@datadog-wireapp
Copy link

Datadog Report

Branch report: refactor/generate-notification-connections
Commit report: 834074d
Test service: wire-ios-mono

✅ 0 Failed, 3200 Passed, 28 Skipped, 3m 10.71s Total Time

@jullianm jullianm changed the title refactor: generate notification user connection - WPB-11660 refactor: generate notification user join (connection) - WPB-11660 Jan 13, 2025
@jullianm jullianm changed the title refactor: generate notification user join (connection) - WPB-11660 refactor: generate notification user contact join - WPB-11660 Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netbe netbe Awaiting requested review from netbe

@johnxnguyen johnxnguyen Awaiting requested review from johnxnguyen

Assignees

@jullianm jullianm

Labels
echoes/initiative: ios-sync-refactoring echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jullianm